Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] Maintain checks and benchmarks and allow custom checks and benchmarks #1873

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

# Conflicts:
#	resotocore/resotocore/report/inspector_service.py
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (35fc7f6) 89.84% compared to head (9ad8bf4) 89.82%.

Files Patch % Lines
resotocore/resotocore/report/inspector_service.py 81.39% 24 Missing ⚠️
resotocore/resotocore/report/__init__.py 76.47% 4 Missing ⚠️
resotocore/resotocore/web/api.py 88.57% 4 Missing ⚠️
resotocore/resotocore/__main__.py 66.66% 1 Missing ⚠️
resotocore/resotocore/dependencies.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1873      +/-   ##
==========================================
- Coverage   89.84%   89.82%   -0.03%     
==========================================
  Files          93       94       +1     
  Lines       16308    16371      +63     
==========================================
+ Hits        14652    14705      +53     
- Misses       1656     1666      +10     
Flag Coverage Δ
resotocore 89.82% <85.02%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias merged commit 1e6110f into main Jan 12, 2024
8 checks passed
@aquamatthias aquamatthias deleted the mv/db_inspector branch January 12, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants