Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] Add AWS WAF Security #1870

Merged
merged 58 commits into from
Jan 10, 2024
Merged

[resotocore][feat] Add AWS WAF Security #1870

merged 58 commits into from
Jan 10, 2024

Conversation

aquamatthias
Copy link
Member

Description

This PR defines the related checks and the benchmark definition for AWS Well Architected.

To-Dos

  • I have created tests for any new or updated functionality.
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0e0899b) 89.84% compared to head (36dfde6) 89.84%.
Report is 2 commits behind head on main.

Files Patch % Lines
resotocore/resotocore/report/inspector_service.py 68.75% 5 Missing ⚠️
resotocore/resotocore/model/model.py 91.66% 2 Missing ⚠️
resotocore/resotocore/db/entitydb.py 87.50% 1 Missing ⚠️
resotocore/resotocore/db/graphdb.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
- Coverage   89.84%   89.84%   -0.01%     
==========================================
  Files          93       93              
  Lines       16256    16308      +52     
==========================================
+ Hits        14606    14652      +46     
- Misses       1650     1656       +6     
Flag Coverage Δ
resotocore 89.84% <87.67%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias changed the title [resotocore][feat] Add AWS WAF [resotocore][feat] Add AWS WAF Security Dec 29, 2023
@aquamatthias aquamatthias marked this pull request as ready for review January 4, 2024 17:12
@aquamatthias aquamatthias merged commit 35fc7f6 into main Jan 10, 2024
28 checks passed
@aquamatthias aquamatthias deleted the mv/waf_part_2 branch January 10, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants