Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resotocore][feat] Towards AWS WAF Security #1867

Merged
merged 11 commits into from
Dec 21, 2023
Merged

[resotocore][feat] Towards AWS WAF Security #1867

merged 11 commits into from
Dec 21, 2023

Conversation

aquamatthias
Copy link
Member

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (177ea49) 89.82% compared to head (e9cbcee) 89.84%.

Files Patch % Lines
resotocore/resotocore/cli/command.py 96.42% 2 Missing ⚠️
resotocore/resotocore/model/model.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
+ Coverage   89.82%   89.84%   +0.02%     
==========================================
  Files          93       93              
  Lines       16177    16252      +75     
==========================================
+ Hits        14531    14602      +71     
- Misses       1646     1650       +4     
Flag Coverage Δ
resotocore 89.84% <94.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aquamatthias aquamatthias merged commit c151817 into main Dec 21, 2023
29 checks passed
@aquamatthias aquamatthias deleted the mv/aws_waf_sec branch December 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants