-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure] [feat] Add new relationships between network resources #1838
Conversation
159e8cf
to
0827cb6
Compare
5648a4d
to
7803c56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Please review the list of edges with respect to successor/predecessor (reverse=true).
I would also question most/all calls that are done in post_process
- do we really need them?
Please find my comments.
And I forgot: AzureSubnet: shouldn't this be a resource? |
008ee38
to
e442a2f
Compare
We can't take URI Parameters
|
a63f52b
to
a846c9f
Compare
b89a151
to
d5f8559
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
==========================================
+ Coverage 89.79% 89.82% +0.03%
==========================================
Files 91 93 +2
Lines 15811 16036 +225
==========================================
+ Hits 14197 14404 +207
- Misses 1614 1632 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d5f8559
to
1b88c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A couple of last comments before we can merge it.
6145454
to
15dc3eb
Compare
d078afb
to
6975927
Compare
5045449
to
2e40c46
Compare
3761956
to
af539ee
Compare
Description
Added
connect_in_graph
method to the network resources.Also added a tests to the new collected resources.
Fixed error with nested sub-resources.
To-Dos
tox
Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.