Unset Lock key masks when closing menu #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikeydoherty
reviewed
Jun 7, 2018
src/frontend/menu-keyboard.c
Outdated
| @@ -23,12 +23,17 @@ gboolean brisk_menu_window_key_press(BriskMenuWindow *self, GdkEvent *event, | |||
| __brisk_unused__ gpointer v) | |||
| { | |||
| autofree(gchar) *accel_name = NULL; | |||
| GdkModifierType lock_maks = GDK_MOD2_MASK | GDK_LOCK_MASK | GDK_MOD5_MASK; | |||
There was a problem hiding this comment.
LOL seriously, I'll fix it right away
This addresses an issue that occurs when trying to close the menu using the configured shortcut without modifiers, but Lock keys (NumLock, etc) are enabled. Fixes solus-project#70
vkareh
force-pushed
the
unset-lock-masks-to-close
branch
from
7d67f1b to
2be1c47
Compare
|
@ikeydoherty - I updated the current commit |
|
It's a working solution. Why has this not been merged? |
|
I've just found this solution and it's been working fine so far. If anything happens I'll let you know. Thank you! |
|
Moving to getsolus/brisk-menu#3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue that occurs when trying to close the menu using the configured shortcut without modifiers, but Lock keys (NumLock, etc) are enabled.
Fixes #70