Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for null or empty embedding request #2104

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

givenscj
Copy link
Contributor

Prevent an empty/null text from being sent to gateway

The issue or feature being addressed

Fixes #{bug number} (in this specific format)

Details on the issue fix or feature implementation

Can cause an infinite loop in langchain/gateway api.

Confirm the following

  • [x ] I started this PR by branching from the head of the default branch
  • [x ] I have targeted the PR to merge into the default branch
  • This PR needs to be cherry-picked into at least one release branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • [x ] I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici merged commit a4a90fb into main Dec 22, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the cjg-gateway-loop-fix branch December 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants