Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we hide the rendering message when completion finishes #2102

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

joelhulen
Copy link
Contributor

@joelhulen joelhulen commented Dec 21, 2024

Make sure we hide the rendering message when completion finishes

The issue or feature being addressed

Ensures the rendering message disappears after the completion ends (fails or completes). The "Rendering" status no longer appears as the message animates, rendering the response when the completed message returns. The "Thinking" status still appears while the completion request is still processing.

Details on the issue fix or feature implementation

N/A

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • This PR needs to be cherry-picked into at least one release branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici merged commit e1ed2a2 into main Dec 21, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the jdh-rendering-message branch December 21, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants