Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Standard to establish a peering to an existing hub VNET #1300

Merged
merged 10 commits into from
Aug 1, 2024
Merged

Update Standard to establish a peering to an existing hub VNET #1300

merged 10 commits into from
Aug 1, 2024

Conversation

hatboyzero
Copy link
Collaborator

Update Standard to establish a peering to an existing hub VNET

Details on the issue fix or feature implementation

Update to Standard deployment to establish a peering to an existing hub VNET and link existing private DNS zones to the FoundationaLLM VNET for DNS resolution of resource endpoints.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

@hatboyzero hatboyzero marked this pull request as ready for review July 30, 2024 01:15
jamesrcounts
jamesrcounts requested changes Jul 30, 2024
View reviewed changes
deploy/standard/azd-hooks/postprovision.ps1 Outdated Show resolved Hide resolved
deploy/standard/infra/dns-rg.bicep Outdated Show resolved Hide resolved
deploy/standard/infra/main.bicep Show resolved Hide resolved
deploy/standard/infra/main.bicep Show resolved Hide resolved
deploy/standard/infra/main.bicep Show resolved Hide resolved
deploy/standard/infra/modules/dns.bicep Show resolved Hide resolved
@jamesrcounts jamesrcounts marked this pull request as draft July 30, 2024 03:02
@hatboyzero hatboyzero marked this pull request as ready for review July 31, 2024 00:13
@hatboyzero hatboyzero marked this pull request as draft July 31, 2024 13:41
@jamesrcounts jamesrcounts marked this pull request as ready for review July 31, 2024 13:48
@ciprianjichici ciprianjichici merged commit ebbb33f into main Aug 1, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the mg-hub-integration branch August 1, 2024 17:20
ciprianjichici added a commit that referenced this pull request Aug 1, 2024
@ciprianjichici
Merge pull request #1321 from solliancenet/mg-t18160-for-release-080
6c7f420 
Cherry-Picked Commits from PR #1300 for Release 0.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciprianjichici ciprianjichici ciprianjichici approved these changes

@jamesrcounts jamesrcounts jamesrcounts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hatboyzero @jamesrcounts @ciprianjichici