Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings management #1293

Merged
merged 16 commits into from
Jul 29, 2024
Merged

Refactor settings management #1293

merged 16 commits into from
Jul 29, 2024

Conversation

ciprianjichici
Copy link
Contributor

@ciprianjichici ciprianjichici commented Jul 27, 2024

Refactor settings management

The issue or feature being addressed

Align the management of settings with the new AIModel and APIEndpoints resources.
Have a single source of the truth for configuration between development and infrastructure.

Details on the issue fix or feature implementation

N/A

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici marked this pull request as ready for review July 28, 2024 01:39
@hatboyzero
Copy link
Collaborator

DataSourceHub API is still looking for the following config setting:

FoundationaLLM:APIs:DataSourceHubAPI:AppInsightsConnectionString

@hatboyzero
Copy link
Collaborator

LangChainAPI is still looking for the following config setting:

FoundationaLLM:APIs:LangChainAPI:AppInsightsConnectionString

@hatboyzero
Copy link
Collaborator

PromptHub API is still looking for the following config setting:

FoundationaLLM:APIs:PromptHubAPI:AppInsightsConnectionString

@hatboyzero
Copy link
Collaborator

Services are crashing on invalid storage account names and invalid AppInsights connection strings. I suspect that some of the settings still do not match up with what is expected.

@ciprianjichici ciprianjichici merged commit 73ff3d2 into main Jul 29, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the cj-refactor-app-config branch July 29, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants