New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a regression resulting from updating HttpClientFactoryService #1281

Merged

joelhulen merged 1 commit into main from cj-fix-tests

Jul 26, 2024

Contributor

ciprianjichici commented Jul 26, 2024 •

edited

Loading

Fixes a regression resulting from updating HttpClientFactoryService

The issue or feature being addressed

A test failed compile as a result of the updates to HttpClientFactoryService.

Details on the issue fix or feature implementation

N/A

Confirm the following

I started this PR by branching from the head of the default branch
I have targeted the PR to merge into the default branch
I have included unit tests for the issue/feature
I have included inline docs for my changes, where applicable
I have successfully run a local build
I have provided the required update scripts, where applicable
I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.


          Fix issue with tests

8ce9785

joelhulen approved these changes

View reviewed changes

joelhulen merged commit baaccd0 into main

9 checks passed

joelhulen deleted the cj-fix-tests branch

July 26, 2024 16:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet