Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management Portal RBAC UI #1112

Merged
merged 61 commits into from
Jul 26, 2024
Merged

Management Portal RBAC UI #1112

merged 61 commits into from
Jul 26, 2024

Conversation

Sensational-Code
Copy link
Collaborator

@Sensational-Code Sensational-Code commented Jun 3, 2024

Management Portal RBAC UI

The issue or feature being addressed

  • Management portal RBAC UI draft with mock data

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@Sensational-Code Sensational-Code marked this pull request as ready for review July 21, 2024 06:46
Copy link
Contributor

@joelhulen joelhulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the following tasks:

  1. When displaying the scope on a resource in the RBAC list, change "This instance" to "This resource" next to a resource assignment directly on the resource (vs. inherited)
  2. When browsing users or groups to assign permissions, make the search query dropdown box filterable.
  3. When displaying user principals in the browse query results, display the email addresses as subtext under each result. This lets the user differentiate between results that have the same name (same person, different accounts, two people with the same name, etc.)

@ciprianjichici ciprianjichici merged commit 2dbb16a into main Jul 26, 2024
9 checks passed
@ciprianjichici ciprianjichici deleted the sc-rbac-management-portal-ui branch July 26, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants