-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Management Portal RBAC UI #1112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liancenet/foundationallm into sc-rbac-management-portal-ui
joelhulen
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete the following tasks:
- When displaying the scope on a resource in the RBAC list, change "This instance" to "This resource" next to a resource assignment directly on the resource (vs. inherited)
- When browsing users or groups to assign permissions, make the search query dropdown box filterable.
- When displaying user principals in the browse query results, display the email addresses as subtext under each result. This lets the user differentiate between results that have the same name (same person, different accounts, two people with the same name, etc.)
…liancenet/foundationallm into sc-rbac-management-portal-ui
ciprianjichici
approved these changes
Jul 26, 2024
joelhulen
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Management Portal RBAC UI
The issue or feature being addressed
Confirm the following
Note
Instead of adding
X
's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.