Update CoreClient library with new message rating endpoint changes

solliancenet · Dec 12, 2024 · 43e68d4 · 43e68d4
1 parent 44c6304
commit 43e68d4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 29 deletions.
diff --git a/src/dotnet/CoreClient/Clients/RESTClients/SessionRESTClient.cs b/src/dotnet/CoreClient/Clients/RESTClients/SessionRESTClient.cs
@@ -127,7 +127,7 @@ public async Task<IEnumerable<Conversation>> GetAllChatSessionsAsync()
         }
 
         /// <inheritdoc/>
-        public async Task<Message> RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating)
+        public async Task RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating)
         {
             if (string.IsNullOrWhiteSpace(sessionId))
             {
@@ -149,10 +149,6 @@ public async Task<Message> RateMessageAsync(string sessionId, string messageId,
             {
                 throw new Exception($"Failed to rate message. Status code: {responseMessage.StatusCode}. Reason: {responseMessage.ReasonPhrase}");
             }
-
-            var responseContent = await responseMessage.Content.ReadAsStringAsync();
-            var message = JsonSerializer.Deserialize<Message>(responseContent, SerializerOptions);
-            return message ?? throw new InvalidOperationException("The returned Message is invalid.");
         }
 
         /// <inheritdoc/>

diff --git a/src/dotnet/CoreClient/CoreClient.cs b/src/dotnet/CoreClient/CoreClient.cs
@@ -63,16 +63,15 @@ public async Task<string> CreateChatSessionAsync(ChatSessionProperties chatSessi
             return sessionId;
         }
 
-        public async Task<Message> RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating)
+        public async Task RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating)
         {
             if (string.IsNullOrWhiteSpace(sessionId))
                 throw new ArgumentException("A session ID must be provided when rating a message.");
             if (string.IsNullOrWhiteSpace(messageId))
                 throw new ArgumentException("A message ID must be provided when rating a message.");
             if (rating == null)
                 throw new ArgumentException("A rating must be provided when rating a message.");
-            var message = await _coreRestClient.Sessions.RateMessageAsync(sessionId, messageId, rating);
-            return message;
+            await _coreRestClient.Sessions.RateMessageAsync(sessionId, messageId, rating);
         }
 
         /// <inheritdoc/>

diff --git a/src/dotnet/CoreClient/Interfaces/ICoreClient.cs b/src/dotnet/CoreClient/Interfaces/ICoreClient.cs
@@ -102,8 +102,7 @@ Task<Message> AttachFileAndAskQuestionAsync(Stream fileStream, string fileName,
         /// <param name="sessionId">The chat session ID that contains the message to rate.</param>
         /// <param name="messageId">The ID of the message to rate.</param>
         /// <param name="rating">The rating and optional comments to assign to the message.</param>
-        /// <returns>Returns the Message object, including its updated rating.</returns>
-        Task<Message> RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating);
+        Task RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating);
 
         /// <summary>
         /// Retrieves agents available to the user for orchestration and session-based requests.

diff --git a/src/dotnet/CoreClient/Interfaces/ISessionRESTClient.cs b/src/dotnet/CoreClient/Interfaces/ISessionRESTClient.cs
@@ -19,8 +19,7 @@ public interface ISessionRESTClient
         /// <param name="sessionId">The chat session ID that contains the message to rate.</param>
         /// <param name="messageId">The ID of the message to rate.</param>
         /// <param name="rating">The rating and optional comments to assign to the message.</param>
-        /// <returns>Returns the Message object, including its updated rating.</returns>
-        Task<Message> RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating);
+        Task RateMessageAsync(string sessionId, string messageId, MessageRatingRequest rating);
 
         /// <summary>
         /// Creates a new session with the specified name.

diff --git a/tests/dotnet/Core.Client.Tests/CoreClientTests.cs b/tests/dotnet/Core.Client.Tests/CoreClientTests.cs
@@ -37,7 +37,7 @@ public async Task CreateChatSessionAsync_WithName_CreatesAndRenamesSession()
         }
 
         [Fact]
-        public async Task RateMessageAsync_ShouldReturnMessage_WhenSuccessful()
+        public async Task RateMessageAsync_ShouldSucceed()
         {
             // Arrange
             var sessionId = "test-session-id";
@@ -47,26 +47,11 @@ public async Task RateMessageAsync_ShouldReturnMessage_WhenSuccessful()
                 Rating = true,
                 Comments = "Great response!"
             };
-            var expectedMessage = new Message
-            {
-                Id = messageId,
-                RatingComments = "This is a test message.",
-                Rating = ratingRequest.Rating
-            };
-
-            _coreRestClient.Sessions
-                .RateMessageAsync(sessionId, messageId, ratingRequest)
-                .Returns(Task.FromResult(expectedMessage));
 
             // Act
-            var result = await _coreClient.RateMessageAsync(sessionId, messageId, ratingRequest);
+            await _coreClient.RateMessageAsync(sessionId, messageId, ratingRequest);
 
             // Assert
-            Assert.NotNull(result);
-            Assert.Equal(expectedMessage.Id, result.Id);
-            Assert.Equal(expectedMessage.RatingComments, result.RatingComments);
-            Assert.Equal(expectedMessage.Rating, result.Rating);
-
             await _coreRestClient.Sessions.Received(1).RateMessageAsync(sessionId, messageId, ratingRequest);
         }