Don't skip the first namespace for controller paths #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielePalombo @mamhoff can you confirm if fixes the issue for your projects? |
mamhoff
reviewed
Jun 15, 2023
| @@ -110,7 +110,7 @@ def enable_solidus_engine_support(engine) | |||
| decorators_path = root.join("lib/decorators/#{engine}") | |||
| controllers_path = root.join("lib/controllers/#{engine}") | |||
| config.autoload_paths += decorators_path.glob('*') | |||
| config.autoload_paths += controllers_path.glob('*') | |||
| config.autoload_paths << controllers_path if controller_path.exist? | |||
There was a problem hiding this comment.
This works, but should the line 112 (just above) not receive the same treatment?
There was a problem hiding this comment.
Good call, I'd expect that folder to have an additional layer and be similar to app/ in that regard, eg. lib/decorators/solidus_foo/models/spree/product/my_decorator.rblib/decorators/frontend/models/spree/product/my_decorator.rb
An example from auth devise:
lib/decorators/frontend/controllers/spree/checkout_controller_decorator.rb
Autoload paths are meant to list autoload roots and not the first
level of the namespace.
E.g. having the following controller in lib/controllers/solidus_foo:
lib/controllers/solidus_foo/spree/my_controller.rb
The autoload will be triggered by a constant reference to
`Spree::MyController` targeting `spree/my_controller.rb` inside
`lib/controllers/solidus_foo/`. This means the autoload path needs to
be `lib/controllers/solidus_foo/`.
elia
force-pushed
the
elia/autoload-paths-fix
branch
from
36d8d26 to
45f1a6a
Compare
kennyadsl
approved these changes
Jun 15, 2023
|
Released in 0.9.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libstopped working #79Summary
Autoload paths are meant to list autoload roots and not the first level of the namespace.
E.g. having the following controller in lib/controllers/solidus_foo:
The autoload will be triggered by a constant reference to
Spree::MyControllertargetingspree/my_controller.rbinsidelib/controllers/solidus_foo/. This means the autoload path needs to belib/controllers/solidus_foo/.See also https://edgeguides.rubyonrails.org/classic_to_zeitwerk_howto.html#globs-in-config-autoload-paths
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: