Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Don't try and add billing address if there is no billing address attached to credit card #120

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Don't try and add billing address if there is no billing address attached to credit card #120

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58d4351
Don't try and add billing address if there is no billing address atta…
joeljackson Aug 30, 2017
2788b0d
Merge pull request #1 from joeljackson/add_to_wallet
joeljackson Oct 1, 2017
267ee4e
Merge branch 'master' of https://github.com/solidusio/solidus_paypal_…
joeljackson Apr 21, 2018
c645d1b
Creates a reference implementation of what an existing payment partia…
joeljackson Apr 21, 2018
082574a
Dont require billing address for paypal.
joeljackson Apr 21, 2018
bfcba5c
Show sensible information for paypal.
joeljackson Apr 21, 2018
b247ab3
Whitespace.
joeljackson Apr 21, 2018
504b3cc
Merge pull request #2 from joeljackson/existing_card
joeljackson Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/solidus_paypal_braintree/gateway.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def transaction_options(source, options, submit_for_settlement = false)
params[:shipping] = braintree_shipping_address(options)
end

if source.credit_card?
if source.credit_card? && options[:bliing_address].present?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have a test for this.

Then you actually would have found your typo as well ;)

params[:billing] = braintree_billing_address(options)
end

Expand Down