Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][Users] Add new admin store credits invalidate flow #6034

Conversation

MadelineCollier
Copy link
Contributor

Summary

This PR is for issue: #5824

This is the second to last piece of the refactored store credits flow. Just missing the flow to create new store credits in the new admin. Again, no designs so I did my best.

Screenshots

Screen.Recording.2024-12-12.at.12.59.40.PM.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.57%. Comparing base (596adae) to head (c734f99).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6034      +/-   ##
==========================================
- Coverage   92.47%   89.57%   -2.91%     
==========================================
  Files         383      790     +407     
  Lines        8333    18224    +9891     
==========================================
+ Hits         7706    16324    +8618     
- Misses        627     1900    +1273     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadelineCollier MadelineCollier marked this pull request as ready for review December 13, 2024 11:48
@MadelineCollier MadelineCollier requested a review from a team as a code owner December 13, 2024 11:48
@MadelineCollier MadelineCollier merged commit 77f8302 into solidusio:main Dec 16, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants