Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin user store credit refactor #6025

Conversation

MadelineCollier
Copy link
Contributor

Summary

I am trying to refactor the store_credits flow so it's a bit smaller and more user friendly. Instead of changing the amount/memo/invalidating the store_credit separately, I can do a modal for editing, and a modal for invalidating.

I am 90% of the way there, but that remaining 10% might actually prove impossible to overcome. I might need to revert back to the old flow of editing memo separately, editing amount separately, editing validity separately. This would be unfortunate, but I am having a hard time getting validations to work as desired what with store_credit_reason_id being off-model and with memo not requiring a reason, but changes to the amount requiring a reason. It is making the update action a bit too complicated. Posting my wip in case anyone has thoughts @kennyadsl @tvdeyen If you'd prefer I just stick to the old flow, let me know and save me some time :)

Screenshot 2024-12-06 at 4 55 58 PM Screenshot 2024-12-06 at 4 56 06 PM

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Dec 6, 2024
@MadelineCollier MadelineCollier force-pushed the admin-user-store-credit-refactor branch from fffb68b to 9dc1797 Compare December 9, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant