Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Give dialogs a little more time to open #6010

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 5, 2024

The default time of 2 seconds is not enough sometimes. Give it 3 more seconds to wait until Capybara raises an error.

The default time of 2 seconds is not enough sometimes.
Give it 3 more seconds to wait until Capybara raises an
error.
@tvdeyen tvdeyen requested a review from a team as a code owner December 5, 2024 07:33
@tvdeyen tvdeyen added backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 and removed changelog:solidus_admin labels Dec 5, 2024
@tvdeyen tvdeyen enabled auto-merge December 5, 2024 07:34
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (18fba3e) to head (a30d802).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6010   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         782      782           
  Lines       18001    18001           
=======================================
  Hits        16104    16104           
  Misses       1897     1897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen added the changelog:repository Changes to the repository not within any gem label Dec 5, 2024
@tvdeyen tvdeyen merged commit d0ccd7e into solidusio:main Dec 5, 2024
20 of 23 checks passed
@tvdeyen tvdeyen deleted the dialog-more-wait-time branch December 5, 2024 12:53
Copy link

github-actions bot commented Dec 5, 2024

💔 Some backports could not be created

Status Branch Result
v4.3 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.3:
- test: Wait for modal to open before testing its content
v4.4

Manual backport

To create the backport manually run:

backport --pr 6010

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants