[v4.2] Use Order#email to show the order's email in new admin #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
backport-v4.2
3 tasks
tvdeyen
removed
backport-v4.2
`spree_orders` table has the column `email` which stores the email of guest orders or users email for non guest orders. We should use that in the new admin to display the email so that guest orders work as well. (cherry picked from commit 93abf41)
tvdeyen
force-pushed
the
backport/v4.2/pr-5596
branch
from
cf95b52 to
87b5c24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.2 #6008 +/- ##
==========================================
- Coverage 92.82% 88.86% -3.97%
==========================================
Files 167 607 +440
Lines 4126 14752 +10626
==========================================
+ Hits 3830 13109 +9279
- Misses 296 1643 +1347 ☔ View full report in Codecov by Sentry. |
MadelineCollier
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.2:Questions ?
Please refer to the Backport tool documentation