Do not constantize Spree.user_class in UserClassHandle #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5999 +/- ##
==========================================
- Coverage 89.46% 87.81% -1.65%
==========================================
Files 782 476 -306
Lines 17999 11658 -6341
==========================================
- Hits 16102 10238 -5864
+ Misses 1897 1420 -477 ☔ View full report in Codecov by Sentry. |
mamhoff
force-pushed
the
easier-user-class-handle
branch
3 times, most recently
from
5f0056c to
7186cc1
Compare
tvdeyen
reviewed
Dec 4, 2024
mamhoff
force-pushed
the
easier-user-class-handle
branch
from
7186cc1 to
bfed7d7
Compare
mamhoff
force-pushed
the
easier-user-class-handle
branch
from
bfed7d7 to
1d6f767
Compare
tvdeyen
added
backport-v4.1
mamhoff
force-pushed
the
easier-user-class-handle
branch
from
1d6f767 to
01da171
Compare
`Spree.user_class` will constantize the configured user class. If called during Rails start-up, this will autoload the configured user class, `Spree.user_class`. We can do without the autoloading by directly getting the name of the class from a new method `Spree.user_class_name`.
mamhoff
force-pushed
the
easier-user-class-handle
branch
from
01da171 to
355ba7a
Compare
tvdeyen
reviewed
Dec 4, 2024
| @@ -21,8 +21,8 @@ class UserClassHandle | |||
| # @return [String] the name of the user class as a string. | |||
| # @raise [RuntimeError] if Spree.user_class is nil | |||
| def to_s | |||
| fail "'Spree.user_class' has not been set yet." unless Spree.user_class | |||
| "::#{Spree.user_class}" | |||
| fail "'Spree.user_class' has not been set yet." unless Spree.user_class_name | |||
There was a problem hiding this comment.
I wonder of a present check makes sense?
Suggested change
| fail "'Spree.user_class' has not been set yet." unless Spree.user_class_name | |
| fail "'Spree.user_class' has not been set yet." unless Spree.user_class_name.present? |
This was referenced Dec 4, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spree.user_classwill constantize the configured user class. If called during Rails start-up, this will autoload the configured user class, which is not necessarily desired. We can do without the autoloading by directly getting the name of the class from a new methodSpree.user_class_name.