[v4.4] test: Wait for modal to open before testing its content #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Capybara needs to be told to expect that the modal is open before we can check for content present in it. Fixes a lot of extremely flaky specs. (cherry picked from commit c67f75f)
If the modal cannot be openend after 5 seconds (Capybara default wait tiem is 3 seconds) then something is wrong. We must not waste precious resources and time for a buld to fail. (cherry picked from commit 7112488)
github-actions
bot
force-pushed
the
backport/v4.4/pr-5993
branch
from
9e651a6 to
c1b5ad2
Compare
github-actions
bot
added
changelog:solidus_legacy_promotions
tvdeyen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.4:Questions ?
Please refer to the Backport tool documentation