Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show all results to en.yml #5988

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Dec 3, 2024

Summary

Adding missing strings to complete substitution of hard coded strings with translated strings in starter front-end and admin backend.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@fthobe fthobe requested a review from a team as a code owner December 3, 2024 12:42
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.45%. Comparing base (1329331) to head (b41952f).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5988      +/-   ##
==========================================
+ Coverage   87.81%   89.45%   +1.64%     
==========================================
  Files         476      782     +306     
  Lines       11656    17997    +6341     
==========================================
+ Hits        10236    16100    +5864     
- Misses       1420     1897     +477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl kennyadsl merged commit ca48c2d into solidusio:main Dec 3, 2024
16 checks passed
@tvdeyen tvdeyen added the backport-v4.4 Backport this pull-request to v4.4 label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants