Backend: Add missing error translation #5979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_backend
tvdeyen
added
backport-v4.0
|
@mamhoff there is this in the failing builds |
auto-merge was automatically disabled
December 2, 2024 17:55
Head branch was pushed to by a user without write access
mamhoff
force-pushed
the
fix-missing-translation-spec
branch
from
6f06da5 to
d2fa51b
Compare
|
Fixed |
jarednorman
approved these changes
Dec 2, 2024
We were missing a translation here, but never noticed, because we were
not testing for an actual human-understandable string.
This is broken in the v4.0, v4.1, v4.2 and v4.3 branches with a noisier
error message, because in those branches, `I18n.t("unavailable")` is
different from `t("unavailable")`.
mamhoff
force-pushed
the
fix-missing-translation-spec
branch
from
d2fa51b to
506ddfc
Compare
|
Force-pushed to force a spec re-run, as the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5979 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 476 476
Lines 11656 11656
=======================================
Hits 10236 10236
Misses 1420 1420 ☔ View full report in Codecov by Sentry. |
tvdeyen
added
backport-v4.0
This was referenced Dec 3, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This was referenced Dec 3, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a translation here, but never noticed, because we were not testing for an actual human-understandable string.
This is broken in the v4.0, v4.1, v4.2 and v4.3 branches with a noisier error message, because in those branches,
I18n.t("unavailable")is different fromt("unavailable").