Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.2] Fix JS locale data for release of Money 6.19 #5977

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Dec 2, 2024

Backport

This will backport the following commits from main to v4.2:

Questions ?

Please refer to the Backport tool documentation

@github-actions github-actions bot requested a review from a team as a code owner December 2, 2024 16:18
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Dec 2, 2024
The money gem in its latest iteration added a space between value and
unit of the Swiss Franc. Our heuristic in `_js_locale_data.html.erb`
can't deal with that, so we add a third branch to it: If the money gem
has a format wish, we'll respect it, but replace its abbreviations with
the one the `accounting.js` library prefers.

(cherry picked from commit f19e6fc)
@github-actions github-actions bot force-pushed the backport/v4.2/pr-5683 branch from 2b30858 to 3676954 Compare December 2, 2024 16:18
@github-actions github-actions bot force-pushed the backport/v4.2/pr-5683 branch from 3676954 to 31704bb Compare December 2, 2024 16:18
@tvdeyen tvdeyen merged commit cc645f9 into v4.2 Dec 2, 2024
@tvdeyen tvdeyen deleted the backport/v4.2/pr-5683 branch December 2, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants