Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0] [FIX] Remove spacing at top of OrderShipping#ship method #5970

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix spacing at top of OrderShipping#ship method
Newest version of Rubocop wants us to remove extra spacing at the top of
method bodies.

(cherry picked from commit 6d44a13)
adammathys committed Dec 2, 2024
commit e52f62afaebd58676d16b92ae35df57df6fc7002
1 change: 0 additions & 1 deletion core/app/models/spree/order_shipping.rb
Original file line number Diff line number Diff line change
@@ -44,7 +44,6 @@ def ship_shipment(shipment, external_number: nil, tracking_number: nil, suppress
# @return The carton created.
def ship(inventory_units:, stock_location:, address:, shipping_method:,
shipped_at: Time.current, external_number: nil, tracking_number: nil, suppress_mailer: false)

carton = nil

Spree::InventoryUnit.transaction do