Bumped license years and added font license #5948
Conversation
Aligned license.md with reality: - added icon license (required by the icon license) - added solidus own FreeBSD license - bumped year of the license to 2024
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
==========================================
- Coverage 89.54% 89.45% -0.09%
==========================================
Files 782 782
Lines 17997 17997
==========================================
- Hits 16116 16100 -16
- Misses 1881 1897 +16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
IANAL and am unsure of best practices around this.
On the RemixIcon license: My gut tells me we should include the licenses as separate files, but I'd love to see examples of what other projects do here. I'm also curious if we need to have these icons included in the repo itself at all, or if they can be included via a package, rendering the licensing issue moot.
On the change of the Solidus license: "solidus.io" is not a legal entity and can't hold a copyright and I don't know what right we have to change the license anyway (even if the only change is the copyright holders).
It says right there in the existing license, "Redistributions of source code must retain the above copyright notice". We can't just change that. That's not how software licensing works.
|
Regarding the remix icon license. Good practice is to put it right beside where the icon file lives. Definitely not inside our license file. Regarding the solidus vs. spree license. My gut tells me to have two separate files, but I would like to see examples of how other forks of open source software handled this in the past before we make any decisions. *) Obvious IANAL disclaimer |
This is TBH personal preference and I feel absolutely ok with both. How about I make a pull request just for that as we all seem to have common ground here.
I would warmly suggest that there's a decision regarding the copyright party picking either of
I have to check very strictly due to external compliance requirements, but I have the feeling that compliance has been neglected a little on this repo. Surely no active copy right owner can't be right as long as the code is not public domain (which by force of the BSD license it is not). Just keep in mind that there are (might be interesting for you @jarednorman) forms of not incorporated associations (would be the nicht eingetragener Verein in Germany) and here the threshold might already be met given a clear code of conduct, but not for Italy for example. I know that right now I would not implement solidus (nor spree) for the given issues in our application stack (usually where there's smoke there's fire). |
|
"other contributors" covers all the other groups of people that contribute to Solidus, and so I believe we only need to update the dates on the existing license. Spree Commerce Inc. (if the entity even still exists) retains the copyright of their contributions that still exist in the project. |
Man, there's not much spree is doing better, but the license stuff definitely. As far as I understood some active companies are contributing (Nebulab, supergood,...) take some credit and put your label on it. It's FreeBSD license anyway. Surely Spree Inc can't have it for anything dating after the liquidation and nobody is gonna claim damages for anything as this software is free as a bird. You people run the show and as mildly annoying as I personally might find that, credit definitely goes to you people.
|
|
Alright, we should retain the existing license then and add an additional copyright line specifying that going forward that the copyright holders are the members of core and other contributors. Something like that. |
Hey, |
|
Yes, we discussed that internally and everyone agreed that having a lawyer make the correct call for us here is the best course of action. |
|
ok guys,
I have a strong preference for cumulative license.md files, but I understand diverging preferences. Do we have anything apart from the icons and tailwind that needs to be licensed separately? Missing Licenses
|
Summary
The license file was not aligned with the legal requiremenets of the assets contained in the repo.
Modifications made
Aligned license.md with reality:
Fixes: #5947 and bumps FreeBSD license to current year