Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new global variables stylesheet in legacy promotions #5932

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 15, 2024

Prior to this change, the promotion admin would have a blue color scheme, and not the red one that all the other pages have.

Prior to this change, the promotion admin would have a blue color
scheme, and not the red one that all the other pages have.
@mamhoff mamhoff requested a review from a team as a code owner November 15, 2024 20:31
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (e6e0243) to head (21bb837).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5932   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         782      782           
  Lines       17980    17980           
=======================================
  Hits        16099    16099           
  Misses       1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen added type:bug Error, flaw or fault changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem backport-v4.4 Backport this pull-request to v4.4 labels Nov 15, 2024
@kennyadsl kennyadsl merged commit 0ab2779 into solidusio:main Nov 16, 2024
22 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v4.4

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.4 Backport this pull-request to v4.4 changelog:repository Changes to the repository not within any gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem type:bug Error, flaw or fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants