Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the store's currency in the Admin Order Index Component #5929

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

magpieuk
Copy link

Admin order index page doesn't reflect the stores currency.

Summary

Changed admin orders index page to use display_total rather than number_to_currency(order.total) this displays the correct currency for the order rather than defaulting to USD

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Admin order index page doesn't reflect the stores currency.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (e6e0243) to head (06c2755).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5929   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         782      782           
  Lines       17980    17980           
=======================================
  Hits        16099    16099           
  Misses       1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl
Copy link
Member

@magpieuk thanks for the contribution. Can you please post a screenshot of the issue to understand where this happen exactly?

@kennyadsl kennyadsl changed the title Update component.rb Update Admin Order Index Component.rb Nov 15, 2024
@kennyadsl kennyadsl changed the title Update Admin Order Index Component.rb Display the store's currency in the Admin Order Index Component Nov 15, 2024
@magpieuk
Copy link
Author

image

@magpieuk
Copy link
Author

There is also another similar issue here: components/solidus_admin/orders/show/summary/component.html.erb

Not sure when this component is displayed yet to verify though.

@tvdeyen tvdeyen added the type:bug Error, flaw or fault label Nov 18, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you add a test as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants