-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the store's currency in the Admin Order Index Component #5929
base: main
Are you sure you want to change the base?
Conversation
Admin order index page doesn't reflect the stores currency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5929 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 782 782
Lines 17980 17980
=======================================
Hits 16099 16099
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
@magpieuk thanks for the contribution. Can you please post a screenshot of the issue to understand where this happen exactly? |
There is also another similar issue here: components/solidus_admin/orders/show/summary/component.html.erb Not sure when this component is displayed yet to verify though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you add a test as well?
Admin order index page doesn't reflect the stores currency.
Summary
Changed admin orders index page to use display_total rather than number_to_currency(order.total) this displays the correct currency for the order rather than defaulting to USD
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: