-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Line Item Actions to solidus_legacy_promotions #5916
Move Line Item Actions to solidus_legacy_promotions #5916
Conversation
This table belongs to the legacy promotion system and was, unfortunately, missed in the original extraction.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5916 +/- ##
==========================================
- Coverage 89.54% 89.54% -0.01%
==========================================
Files 783 782 -1
Lines 17994 17988 -6
==========================================
- Hits 16113 16107 -6
Misses 1881 1881 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks! We cannot be sure that the migration has not already ran for folks. I think we should introduce a new migration file for this table
legacy_promotions/db/migrate/20160101010001_solidus_one_four_promotions.rb
Show resolved
Hide resolved
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 going in the next patch level release?
Summary
This table belongs to the legacy promotion system and was, unfortunately, missed in the original extraction.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: