-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum Ruby version to 3.1 #5891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog:solidus_api
Changes to the solidus_api gem
changelog:solidus_backend
Changes to the solidus_backend gem
changelog:solidus_core
Changes to the solidus_core gem
changelog:solidus_sample
Changes to the solidus_sample gem
changelog:solidus
Changes to the solidus meta-gem
changelog:solidus_admin
labels
Oct 30, 2024
Rails 7.2 requires it and 3.0 is out of support anyway.
The file lives in tasks and the projects are in the root folder.
Now, with Ruby 3.1 we need to address some code style
We need more time to make checks of flash notices in admin tests.
Sometimes it takes a bit longer to render this button.
Helps to clean the git blame history for these rather large changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5891 +/- ##
==========================================
+ Coverage 87.88% 89.58% +1.70%
==========================================
Files 477 783 +306
Lines 11659 17991 +6332
==========================================
+ Hits 10246 16117 +5871
- Misses 1413 1874 +461 ☔ View full report in Codecov by Sentry. |
jarednorman
approved these changes
Oct 31, 2024
Thanks @tvdeyen! Been talking about this change with other folks at Super Good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:solidus_admin
changelog:solidus_api
Changes to the solidus_api gem
changelog:solidus_backend
Changes to the solidus_backend gem
changelog:solidus_core
Changes to the solidus_core gem
changelog:solidus_sample
Changes to the solidus_sample gem
changelog:solidus
Changes to the solidus meta-gem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #5843 for better visibility
We need at least Ruby 3.1 for Rails 7.2 compatibility and Ruby 3.1 is EOL anyway.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: