Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Ruby version to 3.1 #5891

Merged
merged 7 commits into from
Oct 31, 2024
Merged

Bump minimum Ruby version to 3.1 #5891

merged 7 commits into from
Oct 31, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 30, 2024

Summary

Extracted from #5843 for better visibility

We need at least Ruby 3.1 for Rails 7.2 compatibility and Ruby 3.1 is EOL anyway.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen added this to the 4.4 milestone Oct 30, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner October 30, 2024 10:17
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem changelog:solidus_admin labels Oct 30, 2024
@tvdeyen tvdeyen mentioned this pull request Oct 30, 2024
3 tasks
Rails 7.2 requires it and 3.0 is out of support anyway.
The file lives in tasks and the projects are in the root
folder.
Now, with Ruby 3.1 we need to address some code style
We need more time to make checks of flash notices
in admin tests.
Sometimes it takes a bit longer to render this button.
Helps to clean the git blame history for these rather large changes
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 87.94326% with 17 lines in your changes missing coverage. Please review.

Project coverage is 89.58%. Comparing base (5a9dc62) to head (a9c88c9).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
core/lib/spree/core/importer/product.rb 0.00% 3 Missing ⚠️
...dels/concerns/spree/ordered_property_value_list.rb 0.00% 2 Missing ⚠️
.../lib/spree/testing_support/dummy_app/rake_tasks.rb 0.00% 2 Missing ⚠️
...ore/lib/spree/testing_support/order_walkthrough.rb 0.00% 2 Missing ⚠️
...controllers/spree/admin/option_types_controller.rb 0.00% 1 Missing ⚠️
core/app/mailers/spree/base_mailer.rb 0.00% 1 Missing ⚠️
core/app/mailers/spree/order_mailer.rb 66.66% 1 Missing ⚠️
core/app/models/spree/payment_create.rb 0.00% 1 Missing ⚠️
core/app/models/spree/reimbursement.rb 66.66% 1 Missing ⚠️
core/lib/spree/mailer_previews/carton_preview.rb 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5891      +/-   ##
==========================================
+ Coverage   87.88%   89.58%   +1.70%     
==========================================
  Files         477      783     +306     
  Lines       11659    17991    +6332     
==========================================
+ Hits        10246    16117    +5871     
- Misses       1413     1874     +461     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit f4c1cee into solidusio:main Oct 31, 2024
14 checks passed
@tvdeyen tvdeyen deleted the ruby-3.1 branch October 31, 2024 21:30
@nvandoorn
Copy link
Contributor

Thanks @tvdeyen! Been talking about this change with other folks at Super Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_admin changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants