Update Tailwind executable call for v3.0 #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forkata
force-pushed
the
chore/update-tailwind-ruby-api
branch
from
1c33f35 to
58ca9ea
Compare
|
The |
|
Looks good. Can we make sure that we use at least v3.0 of |
adammathys
approved these changes
Oct 17, 2024
benjaminwil
force-pushed
the
chore/update-tailwind-ruby-api
branch
from
58ca9ea to
35e8bef
Compare
|
@tvdeyen Thanks for catching that. I've updated the commit to include that change. |
tvdeyen
approved these changes
Oct 17, 2024
`solidus_starter_frontend` provides templates including the
`tailwindcss-rails` gem without any version constraints. So when 3.0 was
released this week, it broke CI runs for the Solidus repository.
It appears that the only breaking change is related to the `.executable`
call.
As of `tailwindcss-rails` `>= 3.0` the command for the executable was
extracted to a separate `tailwindcss-ruby` gem, which causes an error
in the rake tasks we generate for the `solidus_admin`.
The error this fixes is:
NoMethodError: undefined method `executable' for Tailwindcss::Commands:Module
Co-authored-by: benjamin wil <[email protected]>
auto-merge was automatically disabled
October 17, 2024 16:44
Head branch was pushed to by a user without write access
benjaminwil
force-pushed
the
chore/update-tailwind-ruby-api
branch
from
35e8bef to
8a6f2cc
Compare
|
@forkata @benjaminwil I cut a new solidus_admin release. Could you please rebase this PR? |
|
realized we do not need a rebase. merging. thanks for fixing 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of
tailwindcss-rails>= 3.0the command for the executable wasextracted to a separate
tailwindcss-rubygem, which causes an error inthe rake tasks we generate for the
solidus_admin.See release changelog here - https://github.com/rails/tailwindcss-rails/releases/tag/v3.0.0
and the documentation for the new gem here - https://github.com/flavorjones/tailwindcss-ruby?tab=readme-ov-file#ruby
The error this fixes is
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: