Performance: Remove includes from Spree::Variant#options_text #5867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it seems like a good idea to include the option types in this instance method on Spree::Variant, it's actually not. This method is likely used in a view context, where the controller will have preloaded the option types and option values already - running `option_values.includes(:option_type)` here will then generate a query even though things are preloaded already.
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5867 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 754 754
Lines 17533 17533
=======================================
Hits 15647 15647
Misses 1886 1886 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Oct 9, 2024
tvdeyen
approved these changes
Oct 9, 2024
jarednorman
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it seems like a good idea to include the option types in this instance method on Spree::Variant, it's actually not. This method is likely used in a view context, where the controller will have preloaded the option types and option values already - running
option_values.includes(:option_type)here will then generate a query even though things are preloaded already.The following are mandatory for all PRs: