[Admin] Display last_sign_in_at in users admin, change default scope
#5850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel pretty strongly that the default scope should be "all" instead of "customers". That way, when presented with a long list the first thought is to filter it, instead of the first thought being "why is this user missing" and then realizing that it's because it's filtering by users with the "customer" role only.
The new users admin interface now shows the last sign in date instead of the date the user was created. It will range between "Never", "Less than a minute ago", "3 days ago", "2 months ago" etc. It uses the built-in logic provided by `ActionView::Helpers::DateHelper#time_ago_in_words`. The specs are a bit tricky and stubby due to the need to keep them general and agnostic of whatever is being used for the `Spree.user_class`.
github-actions
bot
added
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5850 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 749 749
Lines 17395 17399 +4
=======================================
+ Hits 15512 15516 +4
Misses 1883 1883 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are a few smaller pieces which can be broken off of the larger work against issue: #5824
If there is a reason for why the default scope was "Customers" instead of "All" then I am happy to remove that change, but if not I think it's a good one.
Screenshots
This shows the updated "All" default scope and the new "Last active" column.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: