Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new extension point in order updater spec #5814

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Aug 8, 2024

This spec still used one of the old extension points for the promotion system, and #5813 exposed that.

@mamhoff mamhoff requested a review from a team as a code owner August 8, 2024 10:11
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Aug 8, 2024
@kennyadsl
Copy link
Member

@mamhoff can you please rebase now that we merged #5812?

This spec still used one of the old extension points for the promotion
system, and solidusio#5813 exposed that.
@mamhoff mamhoff force-pushed the fix-deprecation-warnings-in-test-suite branch from 9743a4d to 0d6017d Compare August 8, 2024 16:58
@mamhoff
Copy link
Contributor Author

mamhoff commented Aug 8, 2024

Rebased!

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.80%. Comparing base (3e8be72) to head (0d6017d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5814   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files         732      732           
  Lines       17088    17088           
=======================================
  Hits        15175    15175           
  Misses       1913     1913           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennyadsl kennyadsl merged commit 5a6ec9b into solidusio:main Aug 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants