[Admin] Shipping category update

admin/app/components/solidus_admin/shipping_categories/edit/component.html.erb

@@ -0,0 +1,16 @@
+<%= turbo_frame_tag :edit_shipping_category_modal do %>
+  <%= render component("ui/modal").new(title: t(".title")) do |modal| %>
+    <%= form_for @shipping_category, url: solidus_admin.shipping_category_path(@shipping_category), html: { id: form_id } do |f| %>
+      <div class="flex flex-col gap-6 pb-4">
+        <%= render component("ui/forms/field").text_field(f, :name) %>
+      </div>
+      <% modal.with_actions do %>
+        <form method="dialog">
+          <%= render component("ui/button").new(scheme: :secondary, text: t('.cancel')) %>
+        </form>
+        <%= render component("ui/button").new(form: form_id, type: :submit, text: t('.submit')) %>
+      <% end %>
+    <% end %>
+  <% end %>
+<% end %>
+<%= render component("shipping_categories/index").new(page: @page) %>

admin/app/components/solidus_admin/shipping_categories/edit/component.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class SolidusAdmin::ShippingCategories::Edit::Component < SolidusAdmin::ShippingCategories::Index::Component
+  def initialize(page:, shipping_category:)
+    @page = page
+    @shipping_category = shipping_category
+  end
+
+  def form_id
+    dom_id(@shipping_category, "#{stimulus_id}_edit_shipping_category_form")
+  end
+end

admin/app/components/solidus_admin/shipping_categories/edit/component.yml

@@ -0,0 +1,6 @@
+# Add your component translations here.
+# Use the translation in the example in your template with `t(".hello")`.
+en:
+  title: "Edit Shipping Category"
+  cancel: "Cancel"
+  submit: "Update Shipping Category"

admin/app/components/solidus_admin/shipping_categories/index/component.rb

@@ -15,12 +15,29 @@ def actions
     )
   end
 
+  def page_actions
+    render component("ui/button").new(
+      tag: :a,
+      text: t('.add'),
+      href: solidus_admin.new_shipping_category_path, data: { turbo_frame: :new_shipping_category_modal },
+      icon: "add-line",
+      class: "align-self-end w-full",
+    )
+  end
+
+  def turbo_frames
+    %w[
+        new_shipping_category_modal
+        edit_shipping_category_modal
+      ]
+  end
+
   def row_url(shipping_category)
-    spree.edit_admin_shipping_category_path(shipping_category)
+    spree.edit_admin_shipping_category_path(shipping_category, _turbo_frame: :edit_shipping_category_modal)
   end
 
   def search_key
-    :name_or_description_cont
+    :name_cont
   end
 
   def search_url

admin/app/components/solidus_admin/shipping_categories/new/component.html.erb

@@ -0,0 +1,17 @@
+<%= turbo_frame_tag :new_shipping_category_modal do %>
+  <%= render component("ui/modal").new(title: t(".title")) do |modal| %>
+    <%= form_for @shipping_category, url: solidus_admin.shipping_categories_path(page: params[:page], q: params[:q]), html: { id: form_id } do |f| %>
+      <div class="flex flex-col gap-6 pb-4">
+        <%= render component("ui/forms/field").text_field(f, :name) %>
+      </div>
+      <% modal.with_actions do %>
+        <form method="dialog">
+          <%= render component("ui/button").new(scheme: :secondary, text: t('.cancel')) %>
+        </form>
+        <%= render component("ui/button").new(form: form_id, type: :submit, text: t('.submit')) %>
+      <% end %>
+    <% end %>
+  <% end %>
+<% end %>
+
+<%= render component("shipping_categories/index").new(page: @page) %>

admin/app/components/solidus_admin/shipping_categories/new/component.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+class SolidusAdmin::ShippingCategories::New::Component < SolidusAdmin::ShippingCategories::Index::Component
+  def initialize(page:, shipping_category:)
+    @page = page
+    @shipping_category = shipping_category
+  end
+
+  def form_id
+    dom_id(@shipping_category, "#{stimulus_id}_new_shipping_category_form")
+  end
+end

admin/app/components/solidus_admin/shipping_categories/new/component.yml

@@ -0,0 +1,6 @@
+# Add your component translations here.
+# Use the translation in the example in your template with `t(".hello")`.
+en:
+  title: "New Shipping Category"
+  cancel: "Cancel"
+  submit: "Add Shipping Category"

admin/app/controllers/solidus_admin/shipping_categories_controller.rb

@@ -4,13 +4,82 @@ module SolidusAdmin
   class ShippingCategoriesController < SolidusAdmin::BaseController
     include SolidusAdmin::ControllerHelpers::Search
 
-    def index
-      shipping_categories = apply_search_to(
-        Spree::ShippingCategory.order(id: :desc),
-        param: :q,
-      )
+    before_action :find_shipping_category, only: %i[edit update]
 
-      set_page_and_extract_portion_from(shipping_categories)
+    def new
+      @shipping_category = Spree::ShippingCategory.new
+
+      set_index_page
+
+      respond_to do |format|
+        format.html { render component('shipping_categories/new').new(page: @page, shipping_category: @shipping_category) }
+      end
+    end
+
+    def create
+      @shipping_category = Spree::ShippingCategory.new(shipping_category_params)
+
+      if @shipping_category.save
+        respond_to do |format|
+          flash[:notice] = t('.success')
+
+          format.html do
+            redirect_to solidus_admin.shipping_categories_path, status: :see_other
+          end
+
+          format.turbo_stream do
+            # we need to explicitly write the refresh tag for now.
+            # See https://github.com/hotwired/turbo-rails/issues/579
+            render turbo_stream: '<turbo-stream action="refresh" />'
+          end
+        end
+      else
+        set_index_page
+
+        respond_to do |format|
+          format.html do
+            page_component = component('shipping_categories/new').new(page: @page, shipping_category: @shipping_category)
+            render page_component, status: :unprocessable_entity
+          end
+        end
+      end
+    end
+
+    def edit
+      set_index_page
+
+      respond_to do |format|
+        format.html { render component('shipping_categories/edit').new(page: @page, shipping_category: @shipping_category) }
+      end
+    end
+
+    def update
+      if @shipping_category.update(shipping_category_params)
+        respond_to do |format|
+          flash[:notice] = t('.success')
+
+          format.html do
+            redirect_to solidus_admin.shipping_categories_path, status: :see_other
+          end
+
+          format.turbo_stream do
+            render turbo_stream: '<turbo-stream action="refresh" />'
+          end
+        end
+      else
+        set_index_page
+
+        respond_to do |format|
+          format.html do
+            page_component = component('shipping_categories/edit').new(page: @page, shipping_category: @shipping_category)
+            render page_component, status: :unprocessable_entity
+          end
+        end
+      end
+    end
+
+    def index
+      set_index_page
 
       respond_to do |format|
         format.html { render component('shipping_categories/index').new(page: @page) }
@@ -33,8 +102,21 @@ def load_shipping_category
       authorize! action_name, @shipping_category
     end
 
+    def find_shipping_category
+      @shipping_category = Spree::ShippingCategory.find(params[:id])
+    end
+
     def shipping_category_params
-      params.require(:shipping_category).permit(:shipping_category_id, permitted_shipping_category_attributes)
+      params.require(:shipping_category).permit(:name)
+    end
+
+    def set_index_page
+      shipping_categories = apply_search_to(
+        Spree::ShippingCategory.order(id: :desc),
+        param: :q,
+      )
+
+      set_page_and_extract_portion_from(shipping_categories)
     end
   end
 end

admin/config/locales/shipping_categories.en.yml

@@ -4,3 +4,8 @@ en:
       title: "Shipping Categories"
       destroy:
         success: "Shipping categories were successfully removed."
+      create:
+        success: "Shipping category was successfully created."
+      update:
+        success: "Shipping category was successfully updated."
+

admin/config/routes.rb

@@ -56,7 +56,7 @@
   admin_resources :payment_methods, only: [:index, :destroy], sortable: true
   admin_resources :stock_items, only: [:index, :edit, :update]
   admin_resources :shipping_methods, only: [:index, :destroy]
-  admin_resources :shipping_categories, only: [:index, :destroy]
+  admin_resources :shipping_categories, except: [:show]
   admin_resources :stock_locations, only: [:index, :destroy]
   admin_resources :stores, only: [:index, :destroy]
   admin_resources :zones, only: [:index, :destroy]

admin/spec/features/shipping_categories_spec.rb

@@ -19,4 +19,62 @@
     expect(Spree::ShippingCategory.count).to eq(0)
     expect(page).to be_axe_clean
   end
+
+  context "edition" do
+    before do
+      Spree::ShippingCategory.create(name: "a shipping category")
+    end
+
+    it "allows to edit a shipping category" do
+      visit "/admin/shipping_categories"
+      find_row("a shipping category").click()
+
+      expect(page).to have_content("Edit Shipping Category")
+
+      fill_in "Name", with: "a new name"
+
+      click_on "Update Shipping Category"
+      expect(page).to have_content("Shipping category was successfully updated.")
+      expect(Spree::ShippingCategory.find_by(name: "a new name")).to be_present
+    end
+  end
+
+  context "when creating a new shipping category" do
+    let(:query) { "?page=1&q%5Bname_or_description_cont%5D=What" }
+
+    before do
+      visit "/admin/shipping_categories#{query}"
+      click_on "Add new"
+      expect(page).to have_content("New Shipping Category")
+      expect(page).to be_axe_clean
+    end
+
+    it "opens a modal" do
+      expect(page).to have_selector("dialog")
+      within("dialog") { click_on "Cancel" }
+      expect(page).not_to have_selector("dialog")
+      expect(page.current_url).to include(query)
+    end
+
+    context "with valid data" do
+      it "successfully creates a new shipping category, keeping page and q params" do
+        fill_in "Name", with: "Whatever"
+
+        click_on "Add Shipping Category"
+
+        expect(page).to have_content("Shipping category was successfully created.")
+        expect(Spree::ShippingCategory.find_by(name: "Whatever")).to be_present
+        expect(page.current_url).to include(query)
+      end
+    end
+
+    context "with invalid data" do
+      it "fails to create a new shipping category, keeping page and q params" do
+        click_on "Add Shipping Category"
+
+        expect(page).to have_content "can't be blank"
+        expect(page.current_url).to include(query)
+      end
+    end
+  end
 end

core/app/models/spree/shipping_category.rb

@@ -2,6 +2,8 @@
 
 module Spree
   class ShippingCategory < Spree::Base
+    self.allowed_ransackable_attributes = %w[name]
+
     validates :name, presence: true
     has_many :products, inverse_of: :shipping_category
     has_many :shipping_method_categories, inverse_of: :shipping_category