Move promotion admin assets #5699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have our own assets in our controllers.
Promotions don't really have any CSS other than the one for the promotion/edit page. So we only include the CSS there.
This moves those templates, views, and JS files that are necessary for the promotion admin to function to the legacy_promotions gem.
github-actions
bot
added
changelog:solidus_backend
mamhoff
force-pushed
the
move-promotion-admin-assets
branch
from
38cbd2d to
38f0682
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5699 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 700 700
Lines 16653 16655 +2
=======================================
+ Hits 14808 14810 +2
Misses 1845 1845 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the CSS and Javascript that is necessary for the admin promotions edit page from the
backendgem to thelegacy_promotionsgem. This is a continuation of #5685, and fully removes any code that references the promotion system fromsolidus_backend.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: