Fix down migration for promotion_orders promotions foreign key #5642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The most recent migration
AddPromotionOrderPromotionForeignKey
has an incorrect down method.The
remove_foreign_key
method has an incorrect "to_table" in the second parameter.This migration creates a foreign key between
spree_orders_promotions
andspree_promotions
, so the down method should refer tospree_promotions
instead ofspree_orders
.If you rollback this migration you will be removing the foreign key between
spree_orders_promotions
andspree_orders
.This causes the rollback of the previous migration to fail with a
Table 'spree_orders_promotions' has no foreign key for spree_orders
error, as it correctly tries to remove the same foreign key.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: