Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Consistently use label for providing text for table scopes, batch actions and filters #5593

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

elia
Copy link
Member

@elia elia commented Jan 10, 2024

Summary

The names chosen over time weren't consistent.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jan 10, 2024
@elia elia requested a review from a team as a code owner January 10, 2024 17:10
@elia elia requested a review from rainerdema January 10, 2024 17:10
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (64f6a58) 88.66% compared to head (e717cdb) 88.66%.
Report is 2 commits behind head on main.

Files Patch % Lines
...mponents/solidus_admin/products/index/component.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5593   +/-   ##
=======================================
  Coverage   88.66%   88.66%           
=======================================
  Files         683      683           
  Lines       16293    16293           
=======================================
  Hits        14446    14446           
  Misses       1847     1847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elia elia merged commit bb39b3f into main Jan 11, 2024
14 checks passed
@elia elia deleted the elia/admin/table-keys branch January 11, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants