Remove unused actions in controller callbacks #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_backend
kennyadsl
force-pushed
the
kennyadsl/fix-missing-action
branch
from
0979129 to
b95f2dd
Compare
github-actions
bot
added
changelog:solidus_api
kennyadsl
force-pushed
the
kennyadsl/fix-missing-action
branch
from
0f4ec58 to
ff56ef0
Compare
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/fix-missing-action
branch
from
ff56ef0 to
178d3be
Compare
With Rails 7.1, callbacks only work with actions that are defined on the controller. This check allowed us to notice we had this some no more used actions. This commit also enable the new configuration in the dummy app so we will be able to spot new errors. The configuration needs to be defined explicitely because it's not part of the load_defaults but it's copied in the dummy application directly. Took advantage of the change for adding another 7.1-only configuration to the dummy app: config.action_dispatch.show_exceptions = :none
Removed the load_promotion_category method and its corresponding before_action for the non-existent :move action.
rainerdema
force-pushed
the
kennyadsl/fix-missing-action
branch
from
4a9de21 to
7a3b599
Compare
rainerdema
approved these changes
Dec 22, 2023
kennyadsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With Rails 7.1, callbacks only work with actions that are defined
on the controller. This check allowed us to notice we had this some
no more used actions.
This commit also enable the new configuration in the dummy app so we
will be able to spot new errors. The configuration needs to be defined
explicitely because it's not part of the load_defaults but it's copied
in the dummy application directly.
Took advantage of the change for adding another 7.1-only configuration
to the dummy app:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: