Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample images #5560

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

kennyadsl
Copy link
Member

Summary

With this change, all the sample images will have the same aspect ratio, in high-resolution. Previously, some of them were too small and with a different ratio.

Continuation of #5437

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

With this change, all the sample images will have the same aspect ratio,
in high-resolution. Previously, some of them were too small and with a
different ratio.
@kennyadsl kennyadsl self-assigned this Dec 21, 2023
@kennyadsl kennyadsl requested a review from a team as a code owner December 21, 2023 08:50
@github-actions github-actions bot added the changelog:solidus_sample Changes to the solidus_sample gem label Dec 21, 2023
@kennyadsl kennyadsl merged commit bbab696 into solidusio:main Dec 21, 2023
7 checks passed
@kennyadsl kennyadsl deleted the kennyadsl-update-samples branch December 21, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_sample Changes to the solidus_sample gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants