Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing YAML reference to the default database config #5553

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Add a missing YAML reference to the default database config #5553

merged 2 commits into from
Dec 15, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 15, 2023 •
edited
Loading

Summary

cc @tvdeyen @forkata

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 15, 2023
@github-actions github-actions bot added changelog:solidus_core Changes to the solidus_core gem changelog:repository Changes to the repository not within any gem labels Dec 15, 2023
@elia elia marked this pull request as ready for review December 15, 2023 14:59
@elia elia requested a review from a team as a code owner December 15, 2023 14:59
@elia elia requested a review from spaghetticode December 15, 2023 14:59
@elia elia added the backport-v4.2 Backport this pull-request to v4.2 label Dec 15, 2023
@elia elia merged commit 3fe73ad into main Dec 15, 2023
10 checks passed
@elia elia deleted the elia/database-config branch December 15, 2023 15:30
@elia elia added the changelog:skip Changes that we don't want to be listed in the Changelog label Dec 15, 2023
@github-actions GitHub Actions
Copy link

💔 All backports failed

Status Branch Result
❌ v4.2 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 5553

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@mamhoff
Copy link
Contributor

mamhoff commented Dec 6, 2024

This seems like it's missing its backport too #6016

@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 and removed backport-v4.2 Backport this pull-request to v4.2 labels Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2024

💔 All backports failed

Status Branch Result
❌ v4.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 5553

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaghetticode spaghetticode Awaiting requested review from spaghetticode

Assignees

@elia elia

Labels
backport-v4.2 Backport this pull-request to v4.2 changelog:repository Changes to the repository not within any gem changelog:skip Changes that we don't want to be listed in the Changelog changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elia @mamhoff @tvdeyen