Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubocop violations after the latest release #5535

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix rubocop violations after the latest release #5535

merged 1 commit into from
Dec 4, 2023

Conversation

elia
Copy link
Member

@elia elia commented Dec 4, 2023

Summary

Rubocop 1.58 introduced a few new rules.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Dec 4, 2023
@elia elia requested a review from a team as a code owner December 4, 2023 14:49
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem labels Dec 4, 2023
@elia elia mentioned this pull request Dec 4, 2023
Merged
3 tasks
@elia elia requested a review from rainerdema December 4, 2023 14:50
@elia elia merged commit 8a2da21 into main Dec 4, 2023
8 checks passed
@elia elia deleted the elia/rubocop-update branch December 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema