Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Fix menu styles & add a backend menu items importer #5518

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

elia
Copy link
Member

@elia elia commented Nov 27, 2023

Summary

Over time the Spree::Backend and SolidusAdmin menu styles slightly diverged, on top of that whenever a store has menu customization is way more convenient to import them from Backend and maintain them in a single place.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 27, 2023
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_admin labels Nov 27, 2023
@elia elia marked this pull request as ready for review November 27, 2023 11:44
@elia elia requested a review from a team as a code owner November 27, 2023 11:44
@elia elia requested a review from rainerdema November 27, 2023 11:44
@elia elia merged commit 5dd0817 into main Nov 27, 2023
8 checks passed
@elia elia deleted the elia/admin-menu branch November 27, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants