Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Move layout related components under layout/ #5510

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

elia
Copy link
Member

@elia elia commented Nov 13, 2023

Summary

Those components were created in early times, now that we have a well defined system for organizing components we can make them fall under the same rule.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Nov 13, 2023
@elia elia requested a review from rainerdema November 13, 2023 11:42
@elia elia marked this pull request as ready for review November 13, 2023 15:09
@elia elia requested a review from a team as a code owner November 13, 2023 15:09
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #5510 (e636fe0) into main (378ed49) will not change coverage.
Report is 13 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5510   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         627      627           
  Lines       15037    15037           
=======================================
  Hits        13331    13331           
  Misses       1706     1706           
Files Coverage Δ
...ponents/solidus_admin/layout/feedback/component.rb 100.00% <100.00%> (ø)
...lidus_admin/layout/navigation/account/component.rb 100.00% <100.00%> (ø)
...nents/solidus_admin/layout/navigation/component.rb 100.00% <100.00%> (ø)
.../solidus_admin/layout/navigation/item/component.rb 100.00% <100.00%> (ø)
...pp/components/solidus_admin/layout/page_helpers.rb 100.00% <ø> (ø)
...onents/solidus_admin/layout/skip_link/component.rb 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@elia elia merged commit 9ed9a07 into main Nov 14, 2023
10 checks passed
@elia elia deleted the elia/admin/layout-namespace branch November 14, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants