Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveStorage as a core dependency #5479

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 1, 2023

Summary

We use ActiveStorage::Current in our BaseControllers since a3119d5 but we never depended on it.

For stores never having activestorage as dependency this was breaking.

This reverts #5450

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

We use ActiveStorage::Current in our BaseControllers
since a3119d5 but
we never depended on it.

For stores never having activestorage as dependency
this was breaking.
@tvdeyen tvdeyen added backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Nov 1, 2023
@tvdeyen tvdeyen requested a review from a team as a code owner November 1, 2023 15:09
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #5479 (d495087) into main (39b1c92) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5479   +/-   ##
=======================================
  Coverage   88.93%   88.93%           
=======================================
  Files         622      622           
  Lines       14908    14909    +1     
=======================================
+ Hits        13258    13259    +1     
  Misses       1650     1650           
Files Coverage Δ
core/lib/spree/core.rb 98.79% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvdeyen tvdeyen merged commit 6e981d3 into solidusio:main Nov 1, 2023
11 of 12 checks passed
Copy link

github-actions bot commented Nov 1, 2023

💚 All backports created successfully

Status Branch Result
v3.4
v4.0
v4.1
v4.2

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@elia elia changed the title Add activestorage as dependency Add ActiveStorage as a core dependency Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants