Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Introduce ui/forms/address component for order admin checkout #5468

Merged

Conversation

rainerdema
Copy link
Contributor

Summary

This PR adds a new component, ui/forms/address.

Modular approach allows for easier maintenance and potential reuse in other parts of the admin interface.

Screenshot 2023-10-30 at 19 43 39

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Modified input component styling to prevent select elements from appearing
as readonly by default.
@rainerdema rainerdema force-pushed the rainerd/admin/add-ui-forms-address-component branch from 954c79d to 38fb96a Compare October 30, 2023 18:52
@rainerdema rainerdema marked this pull request as ready for review October 30, 2023 19:03
@rainerdema rainerdema requested a review from a team as a code owner October 30, 2023 19:03
@rainerdema rainerdema requested a review from elia October 30, 2023 19:03
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📬

@elia elia merged commit e689e66 into solidusio:main Oct 31, 2023
2 checks passed
@elia elia deleted the rainerd/admin/add-ui-forms-address-component branch October 31, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants