Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Extract a ui/search_panel component from orders/cart #5467

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 27, 2023

Summary

Extract the generic part from the orders/cart component making it reusable for the customer search.
Might not be the last iteration of the generalizing process, but so far this is what we need for the customer search, this PR is itself extracted and isolated for reviewing purposes from the work on the customer picker.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 27, 2023
@elia elia force-pushed the elia/admin/search-panel branch from f1ee754 to 0d1214c Compare October 30, 2023 15:31
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@8e9813a). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5467   +/-   ##
=======================================
  Coverage        ?   88.98%           
=======================================
  Files           ?      620           
  Lines           ?    14892           
  Branches        ?        0           
=======================================
  Hits            ?    13251           
  Misses          ?     1641           
  Partials        ?        0           
Files Coverage Δ
...app/components/solidus_admin/ui/badge/component.rb 100.00% <ø> (ø)
...ponents/solidus_admin/ui/search_panel/component.rb 100.00% <100.00%> (ø)
.../solidus_admin/ui/search_panel/result/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 30, 2023 15:51
@elia elia requested a review from a team as a code owner October 30, 2023 15:51
@elia elia requested a review from rainerdema October 30, 2023 15:51
@elia elia force-pushed the elia/admin/search-panel branch from 0d1214c to 7c3c939 Compare October 31, 2023 10:10
@elia elia requested a review from rainerdema October 31, 2023 10:11
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@elia elia merged commit 94c455b into main Oct 31, 2023
4 checks passed
@elia elia deleted the elia/admin/search-panel branch October 31, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants