-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] Extract a ui/search_panel
component from orders/cart
#5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/admin/search-panel
branch
from
October 30, 2023 15:31
f1ee754
to
0d1214c
Compare
Codecov Report
@@ Coverage Diff @@
## main #5467 +/- ##
=======================================
Coverage ? 88.98%
=======================================
Files ? 620
Lines ? 14892
Branches ? 0
=======================================
Hits ? 13251
Misses ? 1641
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
reviewed
Oct 31, 2023
...n/spec/components/previews/solidus_admin/ui/search_panel/component_preview/overview.html.erb
Outdated
Show resolved
Hide resolved
...n/spec/components/previews/solidus_admin/ui/search_panel/component_preview/overview.html.erb
Outdated
Show resolved
Hide resolved
VC now includes that automatically in the base component.
elia
force-pushed
the
elia/admin/search-panel
branch
from
October 31, 2023 10:10
0d1214c
to
7c3c939
Compare
rainerdema
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract the generic part from the
orders/cart
component making it reusable for the customer search.Might not be the last iteration of the generalizing process, but so far this is what we need for the customer search, this PR is itself extracted and isolated for reviewing purposes from the work on the customer picker.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: