-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinned chrome version #5459
Conversation
Not sure why it is not working. The circle ci orb maintainers recommend to pin a version and the version used in this PR exists according to the official chrome for testing json API https://googlechromelabs.github.io/chrome-for-testing/known-good-versions.json It should work™️ 🤷🏻 |
5356feb
to
c1b0048
Compare
The current version does not exist anymore. We need to update it.
Ah, I needed to update the orb version as well. Working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📍
@solidusio/core-team can we get another approval to make CI work again? 🙏🏻 |
Codecov Report
@@ Coverage Diff @@
## main #5459 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 614 614
Lines 14829 14829
=======================================
Hits 13185 13185
Misses 1644 1644 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
💔 Some backports could not be createdManual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
The current version does not exist anymore. We need to update it.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: