Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned chrome version #5459

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update pinned chrome version #5459

merged 1 commit into from
Oct 25, 2023

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 25, 2023

Summary

The current version does not exist anymore. We need to update it.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner October 25, 2023 15:09
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 25, 2023
@tvdeyen tvdeyen changed the title Remove pinned chrome version Update pinned chrome version Oct 25, 2023
@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 25, 2023

Not sure why it is not working. The circle ci orb maintainers recommend to pin a version and the version used in this PR exists according to the official chrome for testing json API https://googlechromelabs.github.io/chrome-for-testing/known-good-versions.json

It should work™️ 🤷🏻

@tvdeyen tvdeyen force-pushed the revert-5367 branch 3 times, most recently from 5356feb to c1b0048 Compare October 25, 2023 15:31
The current version does not exist anymore. We need to
update it.
@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 25, 2023

Ah, I needed to update the orb version as well. Working now

@tvdeyen tvdeyen added backport-v3.2 backport-v3.3 Backport this pull-request to v3.3 backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 labels Oct 25, 2023
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📍

@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 25, 2023

@solidusio/core-team can we get another approval to make CI work again? 🙏🏻

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5459 (0605c98) into main (d479d6a) will not change coverage.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5459   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files         614      614           
  Lines       14829    14829           
=======================================
  Hits        13185    13185           
  Misses       1644     1644           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvdeyen tvdeyen merged commit c0d7d95 into solidusio:main Oct 25, 2023
16 checks passed
@tvdeyen tvdeyen deleted the revert-5367 branch October 25, 2023 19:27
@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v3.2 Backport failed because of merge conflicts
v3.3 Backport failed because of merge conflicts
v3.4 Backport failed because of merge conflicts
v4.0 Backport failed because of merge conflicts
v4.1 Backport failed because of merge conflicts
v4.2

Manual backport

To create the backport manually run:

backport --pr 5459

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.3 Backport this pull-request to v3.3 backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants