Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an orders/cart component #5441

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Add an orders/cart component #5441

merged 6 commits into from
Oct 25, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 17, 2023

Summary

  • add variants
  • change quantity
  • remove line-items
order.cart.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 17, 2023
@elia elia force-pushed the elia/admin/order-cart-component branch 7 times, most recently from 2d07ba2 to c0f421f Compare October 24, 2023 08:38
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #5441 (a07232b) into main (d479d6a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5441      +/-   ##
==========================================
+ Coverage   88.91%   88.96%   +0.05%     
==========================================
  Files         614      617       +3     
  Lines       14829    14876      +47     
==========================================
+ Hits        13185    13235      +50     
+ Misses       1644     1641       -3     
Files Coverage Δ
.../components/solidus_admin/orders/cart/component.rb 100.00% <100.00%> (ø)
...ents/solidus_admin/orders/cart/result/component.rb 100.00% <100.00%> (ø)
.../components/solidus_admin/orders/show/component.rb 100.00% <100.00%> (ø)
.../app/components/solidus_admin/ui/icon/component.rb 100.00% <100.00%> (ø)
...app/components/solidus_admin/ui/toast/component.rb 100.00% <100.00%> (ø)
...controllers/solidus_admin/line_items_controller.rb 100.00% <100.00%> (ø)
...app/controllers/solidus_admin/orders_controller.rb 100.00% <100.00%> (+27.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia requested a review from rainerdema October 24, 2023 09:01
@elia elia force-pushed the elia/admin/order-cart-component branch 2 times, most recently from 832e607 to 4e61d12 Compare October 24, 2023 10:14
@elia elia marked this pull request as ready for review October 24, 2023 10:14
@elia elia requested a review from a team as a code owner October 24, 2023 10:14
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 Amazing work! 🌟

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, but there are some mandatory things to be updated

@elia elia force-pushed the elia/admin/order-cart-component branch from 4e61d12 to c66567c Compare October 25, 2023 09:30
@elia elia requested a review from tvdeyen October 25, 2023 10:31
@elia elia force-pushed the elia/admin/order-cart-component branch from c66567c to d68654e Compare October 25, 2023 10:38
@elia elia force-pushed the elia/admin/order-cart-component branch from d68654e to a07232b Compare October 25, 2023 12:08
@elia elia merged commit 6f724f3 into main Oct 25, 2023
4 checks passed
@elia elia deleted the elia/admin/order-cart-component branch October 25, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants