-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an orders/cart
component
#5441
Conversation
2d07ba2
to
c0f421f
Compare
Codecov Report
@@ Coverage Diff @@
## main #5441 +/- ##
==========================================
+ Coverage 88.91% 88.96% +0.05%
==========================================
Files 614 617 +3
Lines 14829 14876 +47
==========================================
+ Hits 13185 13235 +50
+ Misses 1644 1641 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
832e607
to
4e61d12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟 Amazing work! 🌟
admin/app/components/solidus_admin/orders/show/component.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, but there are some mandatory things to be updated
admin/app/components/solidus_admin/orders/cart/result/component.js
Outdated
Show resolved
Hide resolved
admin/app/components/solidus_admin/orders/show/component.html.erb
Outdated
Show resolved
Hide resolved
4e61d12
to
c66567c
Compare
This prevents them from being giant when shown in page captures made by capybara.
c66567c
to
d68654e
Compare
d68654e
to
a07232b
Compare
Summary
order.cart.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: