Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin tooltip improvements #5439

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Admin tooltip improvements #5439

merged 3 commits into from
Oct 16, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 16, 2023 •
edited
Loading

Summary

image We plan to add proper automatic placement over time, but for now it's just removing things that were taken off the original designs.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Oct 16, 2023
@elia elia force-pushed the elia/admin/tooltips branch from 3254c1b to 17018e4 Compare October 16, 2023 10:30
@elia
Simplify the ui/toggletip component
6777dc6 
- Use the position in reference to the bubble instead of the arrow
  (previously up meant the bubble was below)
- Remove the light theme (currently unused)
- Inline styles and use strings instead of arrays
@elia elia force-pushed the elia/admin/tooltips branch from 17018e4 to 6777dc6 Compare October 16, 2023 10:33
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #5439 (6777dc6) into main (33e539d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5439      +/-   ##
==========================================
- Coverage   88.89%   88.89%   -0.01%     
==========================================
  Files         612      612              
  Lines       14808    14798      -10     
==========================================
- Hits        13164    13154      -10     
  Misses       1644     1644
Files Coverage Δ
...components/solidus_admin/ui/toggletip/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 16, 2023 10:57
@elia elia requested a review from a team as a code owner October 16, 2023 10:57
@elia elia requested a review from rainerdema October 16, 2023 10:57
rainerdema
rainerdema approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

admin/app/components/solidus_admin/ui/toggletip/component.rb Show resolved Hide resolved
@elia elia merged commit e097f4a into main Oct 16, 2023
4 checks passed
@elia elia deleted the elia/admin/tooltips branch October 16, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

Assignees

@elia elia

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema