Don't capture NameError if its not a missing component
#5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of rescuing NameError we proactively check if the requested component is available. This is made possible by Zeitwerk using `autoload` under the hood and having all loadable constants respond `true` when asked if they are `const_defined?`.
Codecov Report
@@ Coverage Diff @@
## main #5432 +/- ##
=======================================
Coverage 88.85% 88.86%
=======================================
Files 609 609
Lines 14784 14786 +2
=======================================
+ Hits 13137 13139 +2
Misses 1647 1647
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
elia
changed the title
NameError if its not a missing component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of rescuing NameError we proactively check if the requested component is available. This is made possible by Zeitwerk using
autoloadunder the hood and having all loadable constants respondtruewhen asked if they areconst_defined?.This change is in response of having a bad constant name inside a component being reported as a typo in the component name.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: